Don't check flush count in internal/stanza converter tests #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
+ Coverage 91.59% 91.61% +0.01%
==========================================
Files 486 486
Lines 23519 23519
==========================================
+ Hits 21543 21547 +4
+ Misses 1466 1463 -3
+ Partials 510 509 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Apr 15, 2021
|
Does this resolve #3128 ? |
pmalek-sumo
deleted the
dont-check-flush-count-in-internal-stanza-converter-tests
branch
Yes, it does. |
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…metry#3130) Don't check flush count - the important bit not check is only the actual number of records in the flushed `pdata.Logs`. **Link to tracking Issue:** open-telemetry#3128 **Testing:** Tweaked unit tests conditions and add a test case
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
This change was a part of #2964 but it's closed now. Having typed arguments make it easier to massage the arguments before comparing. Contributing this change for future maintainers.
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…metry#3130) Don't check flush count - the important bit not check is only the actual number of records in the flushed `pdata.Logs`. **Link to tracking Issue:** open-telemetry#3128 **Testing:** Tweaked unit tests conditions and add a test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Don't check flush count - the important bit not check is only the actual number of records in the flushed
pdata.Logs.Link to tracking Issue: #3128
Testing: Tweaked unit tests conditions and add a test case