Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestAllConvertedEntriesAreSentAndReceived is unstable #3128

Closed
tigrannajaryan opened this issue Apr 15, 2021 · 2 comments
Closed

TestAllConvertedEntriesAreSentAndReceived is unstable #3128

tigrannajaryan opened this issue Apr 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@tigrannajaryan
Copy link
Member

The test failed on CI: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/12446/workflows/0703fc17-7b2a-404e-926b-60d85e76935d/jobs/106913

--- FAIL: TestAllConvertedEntriesAreSentAndReceived (0.00s)
    --- FAIL: TestAllConvertedEntriesAreSentAndReceived/2 (0.02s)
        converter_test.go:198: 
            	Error Trace:	converter_test.go:198
            	Error:      	Not equal: 
            	            	expected: 5
            	            	actual  : 6
            	Test:       	TestAllConvertedEntriesAreSentAndReceived/2
FAIL
coverage: 98.0% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/stanza	0.213s
FAIL
@tigrannajaryan tigrannajaryan added the bug Something isn't working label Apr 15, 2021
@tigrannajaryan
Copy link
Member Author

@pmalek-sumo you are the author of the test, can you please have a look?

@pmalek-sumo pmalek-sumo mentioned this issue Apr 15, 2021
Merged
@pmalek-sumo
Copy link
Contributor

@tigrannajaryan #3130 should help with this test bothering us

tigrannajaryan pushed a commit that referenced this issue Apr 15, 2021
@pmalek-sumo
Don't check flush count in internal/stanza converter tests (#3130)
aaee7c7 
Don't check flush count - the important bit not check is only the actual number of records in the flushed `pdata.Logs`.

**Link to tracking Issue:** #3128

**Testing:** Tweaked unit tests conditions and add a test case
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this issue Apr 28, 2021
@pmalek-sumo @pmatyjasek-sumo
Don't check flush count in internal/stanza converter tests (open-tele…
4b04dee 
…metry#3130)

Don't check flush count - the important bit not check is only the actual number of records in the flushed `pdata.Logs`.

**Link to tracking Issue:** open-telemetry#3128

**Testing:** Tweaked unit tests conditions and add a test case
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@pavankrish123
Support for Custom Exporter Authenticators as Extensions (#3128)
af71182 
This PR adds support to add client side (exporter) authenticators for HTTP and gRPC clients through extension based authenticators. This is built of top of what was added  for receiver (server) side authenticators via extensions in #2603 

**Link to tracking Issue:** #3115

**Testing:** 
- Did a manual testing for static bearer token.
- Added unit tests
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@jpkrohling
Rename OIDC auth extension (#3247)
6fe96b0 
This PR renames the OIDC Auth Extension to oidcauthextension, following the naming pattern agreed as part of #3128

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@pavankrish123
Port client side authentication interfaces from PR #3128 (#3321)
7cd868d 
This PR ports the client authenticator interfaces from PR #3128  in a piece meal fashion. The interfaces are currently not used by any client configurations and are published for reviewing only. 

Plan is to modify ToClient and ToDialOptions apis once all the clients are prepared per #3287 (core and contrib side as well).

Link to tracking Issue:
#3287 #3282

Testing:
Unit tests, [manual test described (for only oidc)](open-telemetry/opentelemetry-collector#3128 (comment))
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@pavankrish123
Updated configgrpc ToDialOptions and confighttp ToClient apis to take…
5369d7e 
… extensions configuration map (#3340)

This PR is a port of the configfrpc's ToDialOptions() and confighttp ToClient() from PR #3128  in a piece meal fashion. 

The following are the changes
- Refactored configgrpc.PerRPCAuth as extension implementing configauth.GrpcClientAuthenticator
- Plugged in extensions configuration to all the grpc based clients in the core (OTLP, OpenCensus, Jaeger, JaegerReceiver)
- Plugged in extensions configuration to all the HTTP based clients in the core (Zipkin, OTLPHTTP)

Link to tracking Issue:
 #3282 #3276

Testing:
Unit tests, [manual test described (for only oidc)](#3128 (comment))
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this issue Aug 31, 2021
@pmalek-sumo
Don't check flush count in internal/stanza converter tests (open-tele…
591db5a 
…metry#3130)

Don't check flush count - the important bit not check is only the actual number of records in the flushed `pdata.Logs`.

**Link to tracking Issue:** open-telemetry#3128

**Testing:** Tweaked unit tests conditions and add a test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tigrannajaryan @pmalek-sumo