Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2974 #2975

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix #2974 #2975

merged 1 commit into from
Apr 1, 2021

Conversation

pmcollins
Copy link
Member

Resolves discrepancy between #2897 and open-telemetry/opentelemetry-collector#2809.

@pmcollins pmcollins requested a review from a team as a code owner April 1, 2021 18:17
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2975 (785d571) into main (5fe49ca) will increase coverage by 22.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2975       +/-   ##
===========================================
+ Coverage   68.96%   91.53%   +22.56%     
===========================================
  Files          34      464      +430     
  Lines        1608    22799    +21191     
===========================================
+ Hits         1109    20868    +19759     
- Misses        425     1438     +1013     
- Partials       74      493      +419     
Flag Coverage Δ
integration 68.96% <ø> (ø)
unit 90.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/lokiexporter/config.go 100.00% <0.00%> (ø)
receiver/collectdreceiver/collectd.go 92.53% <0.00%> (ø)
exporter/f5cloudexporter/factory.go 91.66% <0.00%> (ø)
receiver/nginxreceiver/scraper.go 82.75% <0.00%> (ø)
exporter/signalfxexporter/correlation/spanshims.go 100.00% <0.00%> (ø)
exporter/honeycombexporter/translator.go 100.00% <0.00%> (ø)
receiver/receivercreator/factory.go 71.42% <0.00%> (ø)
extension/observer/hostobserver/extension.go 94.69% <0.00%> (ø)
exporter/datadogexporter/attributes/attributes.go 100.00% <0.00%> (ø)
...xporter/alibabacloudlogserviceexporter/uploader.go 96.87% <0.00%> (ø)
... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe49ca...785d571. Read the comment docs.

@bogdandrutu bogdandrutu merged commit a241ba8 into open-telemetry:main Apr 1, 2021
@pmcollins pmcollins deleted the fix-2974 branch April 1, 2021 18:42
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants