Generate azure_resource_id #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2897 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.01%
==========================================
Files 463 463
Lines 22834 22874 +40
==========================================
+ Hits 20872 20912 +40
Misses 1468 1468
Partials 494 494
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Code taken from https://github.com/signalfx/signalfx-agent/blob/master/pkg/core/hostid/azure.go#L18 with minor modifications. Tested on Azure (standalone VM and Scale Set).
asuresh4
reviewed
Mar 29, 2021
asuresh4
approved these changes
Mar 29, 2021
jrcamp
approved these changes
Apr 1, 2021
Merged
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
Code taken from https://github.com/signalfx/signalfx-agent/blob/master/pkg/core/hostid/azure.go#L18 with minor modifications. Tested on Azure (standalone VM and Scale Set).
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
…2897) In Prometheus, `job` and `instance` are the two auto generated labels, however they are both dropped by prometheus receiver. Although these information is still available in `service.name` and `host`:`port`, it breaks the data contract for most Prometheus users (who use `job` and `instance` to consume metrics in their own system). This PR adds `job` and `instance` as well-known labels in prometheus receiver to fix the issue. **Link to tracking Issue:** open-telemetry/opentelemetry-collector#575 open-telemetry/opentelemetry-collector#2499 open-telemetry/opentelemetry-collector#2363 open-telemetry/wg-prometheus#7
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
…orter (#2979) This is a follow up to #2897. Fixes #575 Fixes #2499 Fixes #2363 Fixes open-telemetry/wg-prometheus#37 Fixes open-telemetry/wg-prometheus#39 Fixes open-telemetry/wg-prometheus#44 Passing compliance tests: $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Job.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector === RUN TestRemoteWrite/otelcollector/JobLabel === PAUSE TestRemoteWrite/otelcollector/JobLabel === CONT TestRemoteWrite/otelcollector/JobLabel --- PASS: TestRemoteWrite (10.02s) --- PASS: TestRemoteWrite/otelcollector (0.00s) --- PASS: TestRemoteWrite/otelcollector/JobLabel (10.02s) PASS ok github.com/prometheus/compliance/remote_write 10.382s $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Instance.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector === RUN TestRemoteWrite/otelcollector/InstanceLabel === PAUSE TestRemoteWrite/otelcollector/InstanceLabel === CONT TestRemoteWrite/otelcollector/InstanceLabel --- PASS: TestRemoteWrite (10.01s) --- PASS: TestRemoteWrite/otelcollector (0.00s) --- PASS: TestRemoteWrite/otelcollector/InstanceLabel (10.01s) PASS ok github.com/prometheus/compliance/remote_write 10.291s $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/RepeatedLabels.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector --- PASS: TestRemoteWrite (0.00s) --- PASS: TestRemoteWrite/otelcollector (0.00s) testing: warning: no tests to run PASS
|
Hi, This is wrong, azure resource name and hostname can be different Actually it generates on some of my VM an ID with localhost inside Azure Resource ID is part of the VM metadata Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource detection processor is running and we're in an Azure environment, we can use the
Azure resource attributes to generate an
azure_resource_id, which is used by the SFx backend.This functionality aims to provide parity with the SFx Smart Agent's generation of
azure_resource_id.Some code taken from https://github.com/signalfx/signalfx-agent/blob/master/pkg/core/hostid/azure.go#L18
Tested on Azure (standalone VM and Scale Set).