[chore][pkg/stanza] Ensure all start/stop calls are in balanced #28294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
changed the title
djaglowski
force-pushed
the
pkg-stanza-fileconsumer-pollstop2
branch
from
9802a28
to
09cbf59
Compare
evan-bradley
approved these changes
Oct 24, 2023
djaglowski
changed the title
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…-telemetry#28294) Follows open-telemetry#28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…-telemetry#28294) Follows open-telemetry#28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #28228
This normalizes calls to
StartandStopacross the test suite.In some cases,
pollis called directly in order to trigger behavior independently of timing. However, we should either usepolldirectly, or use bothStartandStopexactly once. In the future, I expectpollwill be exported and tested directly as part of an internal package.