[chore][pkg/stanaza] Fix and strengthen test case #28228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Oct 23, 2023
djaglowski
added a commit
that referenced
this pull request
Oct 24, 2023
Follows #28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
Follows: open-telemetry#28206 This PR fixes a setup problem with a particular test and further enhances it to make it more robust. The problem was that it restarts a single operator, which is not strictly supported behavior. Instead, a new operator should be created from the same config. The test involves moving a file and then validating that a log written to the original file location is read correctly. This enhances the test to also validate that additional logs written to the original (moved) file will be read as well.
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…-telemetry#28294) Follows open-telemetry#28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Follows: open-telemetry#28206 This PR fixes a setup problem with a particular test and further enhances it to make it more robust. The problem was that it restarts a single operator, which is not strictly supported behavior. Instead, a new operator should be created from the same config. The test involves moving a file and then validating that a log written to the original file location is read correctly. This enhances the test to also validate that additional logs written to the original (moved) file will be read as well.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…-telemetry#28294) Follows open-telemetry#28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows: #28206
This PR fixes a setup problem with a particular test and further enhances it to make it more robust.
The problem was that it restarts a single operator, which is not strictly supported behavior. Instead, a new operator should be created from the same config.
The test involves moving a file and then validating that a log written to the original file location is read correctly. This enhances the test to also validate that additional logs written to the original (moved) file will be read as well.