Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [k8sclusterreceiver] consolidate metadata.yaml #24646

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[chore] [k8sclusterreceiver] consolidate metadata.yaml #24646

merged 1 commit into from
Jul 27, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 27, 2023 •
edited
Loading

Description:

This PR consolidate metadata.yaml and makes all the internal packages to use:

imetadataphase "k8sclusterreceiver/internal/metadata"

instead of:

imetadataphase "k8sclusterreceiver/internal/clusterresourcequota/internal/metadata"

Link to tracking Issue:
#24568

Testing:

  • executed e2e + unit tests

Documentation:

  • generated consolidated docs

@povilasv povilasv mentioned this pull request Jul 27, 2023
Closed
@github-actions github-actions bot requested a review from dmitryax July 27, 2023 13:18
@povilasv povilasv force-pushed the k8sclusterreceiver-consolidate-metadata branch from 87030bc to 5dc8d3c Compare July 27, 2023 13:52
@povilasv povilasv force-pushed the k8sclusterreceiver-consolidate-metadata branch from 5dc8d3c to 1eaf0b3 Compare July 27, 2023 14:10
@povilasv povilasv marked this pull request as ready for review July 27, 2023 14:32
@povilasv povilasv requested a review from a team as a code owner July 27, 2023 14:32
@povilasv
Copy link
Contributor Author

CI failure seems unrelated:
Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')

@dmitryax
Copy link
Member

This is a good first step. Thanks, @povilasv. Are you planning to work on moving the MetricsBuilder and ResourceBuilder outside as in the following PRs?

dmitryax
dmitryax approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povilasv
Copy link
Contributor Author

Yup, this PR is huge so I am trying to split into smaller pieces so its easier to review

@dmitryax dmitryax merged commit 302136b into open-telemetry:main Jul 27, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 27, 2023
@povilasv povilasv deleted the k8sclusterreceiver-consolidate-metadata branch July 28, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees

@codeboten codeboten

Labels
receiver/k8scluster
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@povilasv @dmitryax @codeboten