Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8sclusterreceiver] Allow enabling / disabling metrics #24568

Closed
povilasv opened this issue Jul 26, 2023 · 3 comments
Closed

[k8sclusterreceiver] Allow enabling / disabling metrics #24568

povilasv opened this issue Jul 26, 2023 · 3 comments
Labels
enhancement New feature or request needs triage New item requiring triage

Comments

@povilasv
Copy link
Contributor

povilasv commented Jul 26, 2023 •
edited
Loading

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

We want to enable / disable metrics on k8sclusterreceiver.

Describe the solution you'd like

Similiar to hostmetricsreceiver we want to allow users to disable / enable metrics

Describe alternatives you've considered

No response

Additional context

No response
@povilasv povilasv added enhancement New feature or request needs triage New item requiring triage labels Jul 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Jul 26, 2023
Closed
Closed
@dmitryax
Copy link
Member

@povilasv, we need to consolidate all the metadata.yaml files in one file at the component root level. Also, we need to have one MetricsBuilder and one ResourceBuilder instances for the whole receiver. We should not follow the model from hostmetrics receiver because where they are separated between scrapers

@dmitryax dmitryax mentioned this issue Jul 27, 2023
Closed
@povilasv povilasv mentioned this issue Jul 27, 2023
Merged
@povilasv
Copy link
Contributor Author

WIP in #24646

dmitryax pushed a commit that referenced this issue Jul 27, 2023
@povilasv
[chore] [k8sclusterreceiver] consolidate metadata.yaml (#24646)
302136b 
**Description:**

This PR consolidate metadata.yaml and makes all the internal packages to
use:
```
imetadataphase "k8sclusterreceiver/internal/metadata"
```
instead of:
```
imetadataphase "k8sclusterreceiver/internal/clusterresourcequota/internal/metadata"
```

**Link to tracking Issue:** #24568
@povilasv povilasv mentioned this issue Jul 28, 2023
Merged
dmitryax pushed a commit that referenced this issue Jul 31, 2023
@povilasv
feat: k8sclusterreceiver allow disabling metrics (#24657)
cce00b7 
**Description:** Allow enabling / disabling metrics and resource attributes.

**Link to tracking Issue:** #24568
@povilasv povilasv closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitryax @povilasv