Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add boolean behavior for durations #24272

Merged
merged 16 commits into from
Jul 17, 2023
Merged

feat: add boolean behavior for durations #24272

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a43c31e
feat: add boolean behavior for durations
fchikwekwe Jul 14, 2023
49ddc62
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 14, 2023
926c775
fix: allow item to take type any
fchikwekwe Jul 14, 2023
e8ccc98
Merge branch 'feat/boolean-duration' of https://github.com/fchikwekwe…
fchikwekwe Jul 14, 2023
db7f64e
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 14, 2023
e0c3933
test: use require pkg for error checking
fchikwekwe Jul 17, 2023
ef1773d
Merge branch 'feat/boolean-duration' of https://github.com/fchikwekwe…
fchikwekwe Jul 17, 2023
d80b9a4
fix: add back time var
fchikwekwe Jul 17, 2023
fda657e
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 17, 2023
fcf9042
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 17, 2023
c00477b
doc: add time and duration to comparison doc
fchikwekwe Jul 17, 2023
1ee0b02
Merge branch 'feat/boolean-duration' of https://github.com/fchikwekwe…
fchikwekwe Jul 17, 2023
60362b2
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 17, 2023
f1d3cf5
Update pkg/ottl/README.md
fchikwekwe Jul 17, 2023
b56b13e
Update pkg/ottl/README.md
fchikwekwe Jul 17, 2023
7b6664c
Merge branch 'main' into feat/boolean-duration
fchikwekwe Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: allow item to take type any
  • Loading branch information
@fchikwekwe
fchikwekwe committed Jul 14, 2023
commit 926c775702155d4dbc0902e1358e168abbd900f1
3 changes: 1 addition & 2 deletions pkg/ottl/boolean_value_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func Test_newComparisonEvaluator(t *testing.T) {
WithEnumParser[any](testParseEnum),
)

JanFirst2023 := time.Date(2023, 1, 1, 0, 0, 0, 0, time.Local)
twelveNanoseconds, err := time.ParseDuration("12ns")
if err != nil {
t.Error()
Expand Down Expand Up @@ -116,7 +115,7 @@ func Test_newComparisonEvaluator(t *testing.T) {
l any
r any
op string
item string
item any
want bool
}{
{name: "literals match", l: "hello", r: "hello", op: "==", want: true},
Expand Down