-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add boolean behavior for durations #24272
feat: add boolean behavior for durations #24272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fchikwekwe please take a look at the failing CI, otherwise looks good.
I resolved merge conflicts, and merged a change to fix CI. Just waiting to see if that helped. |
@fchikwekwe looks like one more linter is complaining |
@TylerHelmuth yes, I'm looking into it. This test is passing fine for me locally so I'm not fully understanding why its not passing for this linter. |
I believe you just need to run |
…/opentelemetry-collector-contrib into feat/boolean-duration
@fchikwekwe can you update https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/ottl/README.md#comparison-rules with the time.Time and time.Duration comparison rules? |
@TylerHelmuth I added the documentation that you mentioned to |
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Description: Allows time comparison by enabling boolean behavior for time objects.
Link to tracking Issue: Closes #22713
Testing: Unit tests
Documentation: