[chore] bump govulncheck timeout #21252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 29, 2023
MovieStoreGuy
approved these changes
May 1, 2023
MovieStoreGuy
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #21225
it looks like it is timing out when it has an error getting the cache:
When the golvulncheck step can't read the cache and has to download all the tools before it runs the check we end up hitting the 5 min timeout. I don't have an explanation yet for why the cache doesn't work sometimes, but since we want this to pass every time regardless of its access to the cache I vote we bump the timeout in the meantime. No other step in build-and-test has a dependency on this step so it is ok if it runs a little longer in parallel.