Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][internal/comparetest]Make all exported Compare functions not mutated #17553

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

jackycsl
Copy link
Contributor

Description:
Make all exported Compare functions not mutated for Logs, Metrics, and Traces.
All the data from the source are copied before any mutation is done on the copied data.

Link to tracking Issue:
#17549

Testing:
N/A

Documentation:
N/A

@runforesight
Copy link

runforesight bot commented Jan 13, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 44 minutes 50 seconds compared to main branch avg(44 minutes 55 seconds).
View More Details

✅  telemetrygen workflow has finished in 1 minute 9 seconds (1 minute 31 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 11 seconds (1 minute 22 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 53 seconds (1 minute 7 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 44 seconds (4 minutes 13 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 19 minutes 35 seconds (⚠️ 4 minutes 33 seconds more than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

⭕  changelog workflow has finished in 4 seconds (2 minutes less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 5 seconds (44 minutes 50 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  build-and-test workflow has finished in 33 minutes 38 seconds (15 minutes 12 seconds less than main branch avg.) and finished at 13th Jan, 2023.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@jackycsl jackycsl marked this pull request as ready for review January 13, 2023 02:30
@jackycsl jackycsl requested a review from a team as a code owner January 13, 2023 02:30
@dmitryax
Copy link
Member

Thanks, @jackycsl

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Jan 13, 2023
@codeboten codeboten merged commit 09e2f9b into open-telemetry:main Jan 13, 2023
mms2409 pushed a commit to draios/opentelemetry-collector-contrib that referenced this pull request Jan 19, 2023
…mutated (open-telemetry#17553)

Make all exported Compare functions not mutated for Logs, Metrics, and Traces.
All the data from the source are copied before any mutation is done on the copied data.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/comparetest ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants