Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/comparetest] Make all the exported functions not mutating #17549

Closed
Tracked by #17544
dmitryax opened this issue Jan 12, 2023 · 5 comments
Closed
Tracked by #17544

[internal/comparetest] Make all the exported functions not mutating #17549

dmitryax opened this issue Jan 12, 2023 · 5 comments
Assignees
@jackycsl
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest priority:p2 Medium

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 12, 2023 •
edited
Loading

Currently, the defensive copying is done before applying Sort only for functions comparing top-level entities like CompareMetrics, CompareTraces, and CompareLogs. All other exported functions e.g. CompareLogRecordSlices are mutating because they apply Sort on the provided entities without making a copy before that. This should be fixed. All exported Compare... functions must be not mutating.
@dmitryax dmitryax added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p2 Medium internal/comparetest labels Jan 12, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for internal/comparetest: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax dmitryax mentioned this issue Jan 12, 2023
Closed
9 tasks
@jackycsl
Copy link
Contributor

Can I work on this issue?

@dmitryax
Copy link
Member Author

dmitryax commented Jan 13, 2023 •
edited
Loading

@jackycsl . Sure. Thanks

@jackycsl jackycsl mentioned this issue Jan 13, 2023
Merged
@dmitryax
Copy link
Member Author

Resolved by #17553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackycsl jackycsl

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackycsl @dmitryax