Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awsemfexporter] add log retention feature for Cloudwatch Log Group #15678

Merged
merged 6 commits into from
Nov 7, 2022
Merged

[exporter/awsemfexporter] add log retention feature for Cloudwatch Log Group #15678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfe35e1
Add changes for Log Retention
humivo Oct 25, 2022
5aaeb32
Merge branch 'open-telemetry:main' into AddLogRetention
humivo Oct 25, 2022
4b1f3d7
Add comments to the code
humivo Oct 26, 2022
f98c735
Update README
humivo Oct 26, 2022
fe68e40
Update CHANGELOG
humivo Oct 26, 2022
b1dadef
Add Log Retention config option to awscloudwatchlogsxporter
humivo Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments to the code
  • Loading branch information
@humivo
humivo committed Oct 26, 2022
commit 4b1f3d73b06d059728ab8f49597b75567fd76d5f
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type Config struct {
// "NoDimensionRollup" - No dimension rollup (only keep original metrics which contain all dimensions)
DimensionRollupOption string `mapstructure:"dimension_rollup_option"`

// LogRetention is the option to set the log retenetion policy for the CloudWAtch Log Group. Default to Never Expire if not specified or set to 0
// LogRetention is the option to set the log retention policy for the CloudWatch Log Group. Defaults to Never Expire if not specified or set to 0
// Possible values are 1, 3, 5, 7, 14, 30, 60, 90, 120, 150, 180, 365, 400, 545, 731, 1827, 2192, 2557, 2922, 3288, or 3653
LogRetention int64 `mapstructure:"log_retention"`

Expand Down
1 change: 1 addition & 0 deletions internal/aws/cwlogs/cwlog_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ func (client *Client) CreateStream(logGroup, streamName *string) (token string,
LogGroupName: logGroup,
})
if err == nil {
// For newly created log groups, set the log retention polic if specified or non-zero. Otheriwse, set to Never Expire
if client.logRetention != 0 {
_, err = client.svc.PutRetentionPolicy(&cloudwatchlogs.PutRetentionPolicyInput{LogGroupName: logGroup, RetentionInDays: &client.logRetention})
if err != nil {
Expand Down