[exporter/awsemfexporter] add log retention feature for Cloudwatch Log Group #15678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Nov 3, 2022
| @@ -58,7 +58,7 @@ func newCwLogsPusher(expConfig *Config, params component.ExporterCreateSettings) | |||
| } | |||
|
|
|||
| // create CWLogs client with aws session config | |||
| svcStructuredLog := cwlogs.NewClient(params.Logger, awsConfig, params.BuildInfo, expConfig.LogGroupName, session) | |||
| svcStructuredLog := cwlogs.NewClient(params.Logger, awsConfig, params.BuildInfo, expConfig.LogGroupName, 0, session) | |||
There was a problem hiding this comment.
Should this exporter also get configuration for setting a retention period?
There was a problem hiding this comment.
Hmm I think it could be helpful if there are no objections to adding it
dineshg13
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…g Group (open-telemetry#15678) * Add changes for Log Retention * Add comments to the code * Update README * Update CHANGELOG * Add Log Retention config option to awscloudwatchlogsxporter
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…g Group (open-telemetry#15678) * Add changes for Log Retention * Add comments to the code * Update README * Update CHANGELOG * Add Log Retention config option to awscloudwatchlogsxporter
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a feature to the awsemfexporter that allows you to specify a log retention in the config. This log retention value lets you set the log retention policy for newly created Cloudwatch Log Groups made by the exporter.
Link to tracking Issue:
aws-observability/aws-otel-collector#991
Testing:
Unit testing was added to reflect any code additions.
Documentation:
READMEs were updated to reflect these changes as well as in-code comments.