[internal/aws/cwlogs] Enabling gocritic / errcheck #12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John D <[email protected]>
mx-psi
approved these changes
Jul 12, 2022
mx-psi
added
Skip Changelog
70 tasks
6 tasks
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
) Enabling gocritic / errcheck for internal/aws/cwlogs Signed-off-by: John D <[email protected]>
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
Enabling gocritic / errcheck for internal/aws/cwlogs Signed-off-by: John D <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John D [email protected]
Description: Gocritic / errcheck enabled from aws/cwlogs
Link to tracking Issue: #10466 #9749
Testing: Existing tests
Documentation: None