Enable gocritic in missing components

[mx-psi]

• [exporter/awsemfexporter] Enabling gocritic #12327
• [exporter/awsprometheusremotewriteexporter] enable gocritic #11437
• fix gocritic issue for exporter azuremonitor #10582
• fix gocritic issue for exporter carbon #10590
• [exporter/datadog] fix gocritic issue for datadogexporter #12988
• fix gocritic issue for exporter dynatrace #10595
• fix gocritic issue for exporter elastic #10850
• fix gocritic issue for exporter googlecloudpubsub #10855
• fix gocritic issue for exporter humio #10884
• fix gocritic issue for exporter kafka #10905
• [exporter/loadbalancingexporter] Enable gocritic #11164
• fix gocritic issue for observiq exporter #10909
• Enable gocritic in exporter/prometheusexporter
• Enable gocritic in exporter/prometheusremotewriteexporter
• fix gocritic issue for exporter sentry #10923
• Enable gocritic in exporter/signalfxexporter/internal/translation
• [exporter/skywalkingexporter] Enable gocritic #11162
• Enable gocritic in exporter/splunkhecexporter
• fix gocritic issue for exporter sumologic #11159
• [exporter/tanzuobservabilityexporter] Enable gocritic #11161
• fix lint issue for extension httpforwarder #11026
• fix gocritic issue for extension observer #11066
• [internal/aws/awsutil]Enable gocritic in internal/aws/awsutil #11529
• Enable gocritic in internal/aws/containerinsight
• [internal/aws/cwlogs] Enabling gocritic / errcheck #12328
• Enable gocritic in internal/aws/k8s/k8sclient
• Enable gocritic in internal/aws/proxy
• fix gocritic issue for internal sanitize #11156
• Enable gocritic in internal/coreinternal/processor/filtermatcher
• Enable gocritic in pkg/stanza/adapter
• fix lint error for processor cumulativetodelta #11552
• Enable gocritic in processor/k8sattributesprocessor
• Enable gocritic in processor/metricstransformprocessor
• Enable gocritic in processor/resourcedetectionprocessor/internal/aws/eks
• Enable gocritic in processor/routingprocessor
• Enable gocritic in processor/spanmetricsprocessor
• [processor/spanprocessor]Enable gocritic in processor/spanprocessor #11778
• Enable gocritic in processor/tailsamplingprocessor
• Enable gocritic in processor/transformprocessor/internal/logs
• Enable gocritic in processor/transformprocessor/internal/metrics
• Enable gocritic in processor/transformprocessor/internal/traces
• [receiver/awscontainerinsight] fix lint error for awscontainerinsightreceiver #12325
• Enable gocritic in receiver/awsecscontainermetricsreceiver/internal/awsecscontainermetrics
• Enable gocritic in receiver/awsxrayreceiver/internal/translator
• [receiver/bigip] Enable linters and address issues #11793
• [receiver/carbonreceiver/transport] Enable gocritic #11421
• [receiver/couchdb] Enable linters and fix issues #11794
• Enable gocritic in receiver/dotnetdiagnosticsreceiver/metrics
• Enable gocritic in receiver/dotnetdiagnosticsreceiver/network
• Enable gocritic in receiver/googlecloudpubsubreceiver
• [receiver/googlecloudspannerreceiver] Enable gocritic #12499
• Enable gocritic in receiver/googlecloudspannerreceiver/internal/statsreader
• Enable gocritic in receiver/hostmetricsreceiver/internal/scraper/cpuscraper
• Enable gocritic in receiver/hostmetricsreceiver/internal/scraper/loadscraper
• Enable gocritic in receiver/jmxreceiver/internal/subprocess
• [receiver/k8scluster] fix lint error for k8sclusterreceiver #12214
• [receiver/mongodb] Enable linter and fix issues #11798
• [receiver/nsxt] Enable linter and fix issues #11799
• [receiver/prometheus] Enable linters and fix issues #11806
• [receiver/riak] Enable lint and fix issues #11802
• [receiver/saphana] Enable linters and fix issues #11804
• Enable gocritic in receiver/signalfxreceiver
• Enable gocritic in receiver/skywalkingreceiver
• Enable gocritic in receiver/splunkhecreceiver
• Enable gocritic in receiver/statsdreceiver/protocol
• Enable gocritic in receiver/statsdreceiver/transport
• [receiver/wavefrontreceiver]enable gocritic in wavefrontreceiver #11556
• Enable gocritic in testbed/datareceivers
• [testbed/testbed] Enable gocritic in testbed/testbed #11464
• Enable gocritic in pkg/telemetryquerylanguage

---

List generated by running:

❯ git diff-tree --no-commit-id --name-only -r 0c691295193854523240b609c0c3cc06f9202b41 | rg .go$ | xargs dirname | sort | uniq | awk '{print "- [ ] Enable gocritic in " $0}'

[fatsheep9146]

@mx-psi please assign this to me :)

[fatsheep9146]

@mx-psi I have checked all component, for gocritic only two components are still not resolved, others can all be checked

• exporter/datadogexporter: [exporter/datadog] fix gocritic issue for datadogexporter #12988
• receiver/awscontainerinsightreceiver: [receiver/awscontainerinsight] fix lint error for awscontainerinsightreceiver #12325

[mx-psi]

Nice! Looks like pkg/telemetryquerylanguage/contexts/tqlmetrics/metrics.go is also missing, otherwise we are almost finished :)

[evan-bradley]

@mx-psi Can this issue be closed?

[mx-psi]

❯ rg -tgo gocritic -l | cut -d '/' -f 1-2 | sort | uniq
pkg/ottl
receiver/awscontainerinsightreceive

These are the two components missing:

• The first one has no PR. @TylerHelmuth can you have a look? (Related to pkg/ottl)
• The second one has an open PR ([receiver/awscontainerinsight] fix lint error for awscontainerinsightreceiver #12325) waiting on a review from @Aneurysm9.

[TylerHelmuth]

@mx-psi I'll take a look

[fatsheep9146]

❯ rg -tgo gocritic -l | cut -d '/' -f 1-2 | sort | uniq
pkg/ottl
receiver/awscontainerinsightreceive

These are the two components missing:

• The first one has no PR. @TylerHelmuth can you have a look? (Related to pkg/ottl)
• The second one has an open PR ([receiver/awscontainerinsight] fix lint error for awscontainerinsightreceiver #12325) waiting on a review from @Aneurysm9.

I think this issue is ready to be closed. =D @mx-psi

[mx-psi]

Indeed 🎉 🎉 Thanks for your hard work on this @fatsheep9146 !