[receiver/awscontainerinsight] fix lint error for awscontainerinsightreceiver #12325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@Aneurysm9 could you help review this pr? |
82 tasks
|
Bump @Aneurysm9 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@Aneurysm9 ping |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@Aneurysm9 this has been open for more than two months, it should be easy to review, could you have a look? |
Aneurysm9
reviewed
Sep 30, 2022
receiver/awscontainerinsightreceiver/internal/cadvisor/extractors/fs_extractor.go
Outdated
Show resolved
Hide resolved
fatsheep9146
force-pushed
the
fix-lint-for-awscontainerinsightreceiver
branch
from
899b847
to
b4fc47e
Compare
…receiver Signed-off-by: Ziqi Zhao <[email protected]>
fatsheep9146
force-pushed
the
fix-lint-for-awscontainerinsightreceiver
branch
from
81f3698
to
4427eff
Compare
|
The failed test seems be flaky and not related to this pr. Please help review this again =-D @Aneurysm9 |
Aneurysm9
approved these changes
Oct 12, 2022
|
@mx-psi I think this pr is ready to be merged. =D |
mx-psi
approved these changes
Oct 13, 2022
|
Awesome, we are almost finished with the linters! :) |
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…receiver (open-telemetry#12325) Signed-off-by: Ziqi Zhao <[email protected]> Signed-off-by: Ziqi Zhao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziqi Zhao [email protected]
Description:
fix gocritic and errcheck issue for awscontainerinsightreceiver
Link to tracking Issue:
#10466 #9749