Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Add unit test for OTLP attributes flag #11832

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 30, 2022

Description:

Follow up to #11145, just adding some unit tests I wrote when reviewing this.

Link to tracking Issue: Relates to #11144

@mx-psi mx-psi requested review from a team and jpkrohling as code owners June 30, 2022 09:30
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 30, 2022
@mx-psi
Copy link
Member Author

mx-psi commented Jun 30, 2022

cc @JaredTan95, in case you want to drop a review

@jpkrohling jpkrohling merged commit 3bc0e6b into open-telemetry:main Jul 11, 2022
atoulme pushed a commit to atoulme/opentelemetry-collector-contrib that referenced this pull request Jul 16, 2022
* [tracegen] Add unit test for OTLP attributes flag

* Address linter
ag-ramachandran referenced this pull request in ag-ramachandran/opentelemetry-collector-contrib Sep 15, 2022
* [tracegen] Add unit test for OTLP attributes flag

* Address linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants