[tracegen/cmd] support add additional resource attributes. #11145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Jun 20, 2022
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]> # Conflicts: # CHANGELOG.md
Signed-off-by: jian.tan <[email protected]>
Signed-off-by: jian.tan <[email protected]>
JaredTan95
force-pushed
the
tracegen_add_attributes
branch
from
ac95f9a
to
686a49c
Compare
mx-psi
reviewed
Jun 27, 2022
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
Jun 28, 2022
|
Thanks @JaredTan95 for contributing! :) |
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…metry#11145) * support add additional resource attributes in tracegen. Signed-off-by: jian.tan <[email protected]> * update Signed-off-by: jian.tan <[email protected]> * update Signed-off-by: jian.tan <[email protected]> * add changelog Signed-off-by: jian.tan <[email protected]> # Conflicts: # CHANGELOG.md * fix fmt. Signed-off-by: jian.tan <[email protected]> * update logical Signed-off-by: jian.tan <[email protected]> * Update tracegen/internal/tracegen/config.go Co-authored-by: Pablo Baeyens <[email protected]> * Update tracegen/main.go Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jian.tan [email protected]
Description:
refer the implementation of
otlp-headers:Link to tracking Issue:
#11144
Testing:
Documentation: