6622 show no members message #6718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbert
requested changes
Jul 2, 2020
| @@ -130,6 +130,9 @@ | |||
| <mat-header-row *matHeaderRowDef="displayedColumns"></mat-header-row> | |||
| <mat-row [ngClass]="{'cursor-pointer':!isDialog}" *matRowDef= "let row; columns: displayedColumns;" (click)="gotoProfileView(row.doc.name)" [ngClass]="{highlight:isSelected(row.doc)}"></mat-row> | |||
| </mat-table> | |||
| <ng-template #noUserFoundMessage> | |||
| <div class="view-container">No members available</div> | |||
There was a problem hiding this comment.
view-container should not be used here. It already applies to the containing element.
| @@ -130,6 +130,9 @@ | |||
| <mat-header-row *matHeaderRowDef="displayedColumns"></mat-header-row> | |||
| <mat-row [ngClass]="{'cursor-pointer':!isDialog}" *matRowDef= "let row; columns: displayedColumns;" (click)="gotoProfileView(row.doc.name)" [ngClass]="{highlight:isSelected(row.doc)}"></mat-row> | |||
| </mat-table> | |||
| <ng-template #noUserFoundMessage> | |||
There was a problem hiding this comment.
Please move this below the mat-paginator element. That is related to the table and it's confusing seeing this in the middle.
There was a problem hiding this comment.
Updated both requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6622
Shows an error message if no users are found.