Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogsAddTable/Courses: indicate when no courses are available #6733

Open
Mutugiii opened this issue Jul 2, 2020 · 2 comments
Open

DialogsAddTable/Courses: indicate when no courses are available #6733

Mutugiii opened this issue Jul 2, 2020 · 2 comments
Labels

Comments

@Mutugiii
Copy link
Member

Mutugiii commented Jul 2, 2020

Could we replicate a fix like this that fixes #6622 in the courses dialog table as well?

Also, we could replicate the same fix on other dialogs like in teams, we have add resources as well

oleaddfix

@paulbert
Copy link
Member

paulbert commented Jul 2, 2020

Looks like that has already been implemented for Resources & Courses. Closing.

@paulbert paulbert closed this as completed Jul 2, 2020
@paulbert
Copy link
Member

paulbert commented Jul 2, 2020

Misunderstood. This is asking if we should add the message when there are resources or courses available, but the search text doesn't match any of them.

I think we may need to use something other than *ngIf to hide the table instead of destroying it or maybe there's an option on *ngIf for this.

@paulbert paulbert reopened this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants