Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback title truncation (connects #3936) #4066

Merged
merged 13 commits into from
Sep 30, 2019
Merged

feedback title truncation (connects #3936) #4066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
38e20f9
Shorten url title
Liew211 Jun 13, 2019
4cf7c76
Create parseToObject function
Liew211 Jun 13, 2019
6710471
Fix linter
Liew211 Jun 13, 2019
40fb4e7
Fix linter
Liew211 Jun 13, 2019
8a67889
Update params implementation
Liew211 Jun 18, 2019
a454cf2
Fix codeclimate and display params
Liew211 Jun 18, 2019
7fe9815
Fix codeclimate issue
Liew211 Jun 19, 2019
2ebaf5e
Add toggle button
Liew211 Jun 25, 2019
abbfd52
Small fix
Liew211 Jun 25, 2019
ed85899
Move button
Liew211 Aug 6, 2019
345fccb
Add title and limit button to admins
Liew211 Sep 11, 2019
72dbddd
Cleaner details view
paulbert Sep 30, 2019
52ea77d
Remove unnecessary property on database
paulbert Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix codeclimate and display params
  • Loading branch information
@Liew211 @paulbert
Liew211 authored and paulbert committed Sep 30, 2019
commit a454cf250ffbc97e17974d31b6556f23096b1652
2 changes: 1 addition & 1 deletion src/app/feedback/feedback-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
</mat-toolbar-row>
</mat-toolbar>
<div class="view-container view-full-height">
<div class="feedback-params">{{feedback.params}}</div>
<div class="feedback-params" *ngFor="let prop of feedback.params | keyvalue">{{prop.key}}: {{prop.value}}</div>
<div class="chat-list" #chatList>
<div class="chat-list-item" *ngFor="let message of feedback.messages; trackBy: feedbackTrackByFn">
<div class="chat-list-user">
Expand Down
4 changes: 2 additions & 2 deletions src/app/feedback/feedback.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class Feedback {
source: string;
url: string;
messages: Array<Message>;
params: string;
params: Object;
}

const dialogFieldOptions = [
Expand Down Expand Up @@ -90,13 +90,13 @@ export class FeedbackDirective {
status: 'Open',
messages: [ startingMessage ],
url: this.router.url,
params: parseToObject(this.router.url),
source: this.stateService.configuration.code,
parentCode: this.stateService.configuration.parentCode,
...this.feedbackOf
};
this.couchService.updateDocument('feedback', {
...newFeedback,
params: JSON.stringify(parseToObject(newFeedback.url)),
title: newFeedback.type + ' regarding ' + newFeedback.url.substring(0, newFeedback.url.indexOf(';')) })
.subscribe((data) => {
this.feedbackService.setfeedback();
Expand Down