Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback title truncation (connects #3936) #4066

Merged
merged 13 commits into from
Sep 30, 2019
Merged

Conversation

Liew211
Copy link
Member

@Liew211 Liew211 commented Jun 18, 2019

Screenshot_2019-06-17 Planet Learning

Truncated name, turned params into an object. I'm not sure of the exact method of display, so I used JSON.stringify for a temporary fix, so please let me know what you'd like best for this.

@Liew211 Liew211 requested review from paulbert and lmmrssa June 18, 2019 02:56
@Liew211 Liew211 added the WIP label Jun 18, 2019
@Liew211
Copy link
Member Author

Liew211 commented Jun 18, 2019

Screenshot_2019-06-18 Planet Learning
@paulbert @lmmrssa This is what the page looks like now.

@paulbert
Copy link
Member

@Liew211 If there are parameters, it would be better to only show them after clicking a "Show Page Parameters" button

@Liew211
Copy link
Member Author

Liew211 commented Jun 25, 2019

Screenshot_2019-06-24 Planet Learning
Screenshot_2019-06-24 Planet Learning(1)
I partly copied the toggle functionality from the search filter in resources, let me know if you want the button to be above/below the details, and if the size of the button should be smaller.

@paulbert
Copy link
Member

I think the button should be in the top blue toolbar after the edit button and maybe say "Show URL Details" or "Show Page Details"

Also I think the details should have a different background like with resources/courses so it stands out as different.

@Liew211
Copy link
Member Author

Liew211 commented Jun 28, 2019

@paulbert would a mat-card be ok for the details? Also, should the button be aligned to the right, or just be next to the edit button?

@Liew211
Copy link
Member Author

Liew211 commented Jun 28, 2019

Screenshot_2019-06-28 Planet Learning
@paulbert how's this?

@Liew211 Liew211 added in review and removed WIP labels Jul 23, 2019
@paulbert
Copy link
Member

@Liew211 I like what you have in that screenshot. I think maybe add a line on top in bold that says Page Parameters as a heading and on the show/hide details button add *planetAuthorizedRoles to limit this to admins. I think it would just be confusing for normal members.

@Liew211
Copy link
Member Author

Liew211 commented Sep 11, 2019

@paulbert made the changes, take a look!

@paulbert paulbert merged commit 0905a05 into master Sep 30, 2019
@paulbert paulbert deleted the 3936-feedback-title branch October 1, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants