Remove impl Send for Isolate and EsIsolate (denoland#4151)

ondras · Feb 26, 2020 · fb1075d · fb1075d
1 parent 7fff2d2
commit fb1075d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/core/es_isolate.rs b/core/es_isolate.rs
@@ -82,10 +82,6 @@ impl DerefMut for EsIsolate {
   }
 }
 
-// TODO(ry): a V8 Isolate cannot actually be moved between threads without the
-// use of a Locker, therefore EsIsolate should not implement the `Send` trait.
-unsafe impl Send for EsIsolate {}
-
 impl EsIsolate {
   pub fn new(
     loader: Rc<dyn Loader + Unpin>,

diff --git a/core/isolate.rs b/core/isolate.rs
@@ -182,10 +182,6 @@ pub struct Isolate {
   error_handler: Option<Box<IsolateErrorHandleFn>>,
 }
 
-// TODO(ry): a V8 Isolate cannot actually be moved between threads without the
-// use of a Locker, therefore Isolate should not implement the `Send` trait.
-unsafe impl Send for Isolate {}
-
 impl Drop for Isolate {
   fn drop(&mut self) {
     if let Some(creator) = self.snapshot_creator.take() {