Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl Send for Isolate and EsIsolate #4151

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Remove impl Send for Isolate and EsIsolate #4151

merged 1 commit into from
Feb 26, 2020

Conversation

ry
Copy link
Member

@ry ry commented Feb 26, 2020

No description provided.

@bartlomieju bartlomieju mentioned this pull request Feb 26, 2020
Closed
@ry ry merged commit fb1075d into denoland:master Feb 26, 2020
@ry ry deleted the remove_send branch February 26, 2020 21:10
piscisaureus
piscisaureus approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it just works? Not when I tried it yesterday... maybe that was before changes to the terninate_execution test were made.

@bartlomieju
Copy link
Member

We might want to remove Send from ZeroCopyBuf as well (I did that in #4152).

@piscisaureus
Copy link
Member

@bartlomieju won't that break async file reads (which should be done in the thread pool)?

@bartlomieju
Copy link
Member

Good point; now I also thought about buffer transfer in postMessage(msg, [transfer])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @bartlomieju @piscisaureus