Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): make which_key always appear on top #3050

Closed

Conversation

emmanueltouzery
Copy link
Contributor

Description

Fix displaying the which-key window on top of the main telescope window with at least the neovide GUI.
The default z-index is 50, setting 60 to guarantee displaying on top of the main telescope window.
The current behavior works correctly with the normal neovim implementation by luck only.

Fixes #2976

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

I also believe this fix should be applied to the 0.1.0 branch.

How Has This Been Tested?

  • Ran neovide telescope and triggered which-key with and without the change, confirming the fix works. Also triggered which-key in the neovim CLI and checked it still worked.

Configuration:

  • Neovim version (nvim --version): 0.9.5
  • Operating system and version: fedora 39

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

fixes nvim-telescope#2976
the default z-index is 50, setting 60 to guarantee displaying on top of
the main telescope window.
@emmanueltouzery
Copy link
Contributor Author

well I made this before I noticed #3046 -- closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

which_key action popup is not rendered correctly in neovide
1 participant