Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zindex option for popup action.which_key #3046

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

shcode
Copy link
Contributor

@shcode shcode commented Apr 12, 2024

Description

add zindex option for action.which_key. The current value is 50 which sometimes conflicted with picker window.

Fixes #2976

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran several test (over 50, below 50) in neovide by adding code below and it works as expected.
local action_generate = require 'telescope.actions.generate'
require('telescope').setup {
  defaults = {
    mappings = {
      i = { 
        ['<c-/>'] = action_generate.which_key {
          zindex = 60,
        },
      },
    },
  },
}

Configuration:

  • Neovim version (nvim --version): 0.9.5
  • Operating system and version: darwin-arm64

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@jamestrew
Copy link
Contributor

thanks for this.
closes #2976

@emmanueltouzery
Copy link
Contributor

I have tested this pull request with neovim 0.9.5 and neovide 0.12.1 and I can confirm that it fixes the issue 👍

@emmanueltouzery
Copy link
Contributor

I also believe it's a "Bug fix (non-breaking change which fixes an issue)", and I don't know why this is marked as draft, in my opinion the PR is ready.

@shcode shcode marked this pull request as ready for review April 15, 2024 18:10
@shcode
Copy link
Contributor Author

shcode commented Apr 15, 2024

I also believe it's a "Bug fix (non-breaking change which fixes an issue)", and I don't know why this is marked as draft, in my opinion the PR is ready.

I am sorry, I forgot to continue on this. My bad.
I think it's ready now.

@shcode shcode changed the title add zindex option for popup add zindex option for popup action.which_key Apr 15, 2024
@jamestrew jamestrew merged commit a328495 into nvim-telescope:master Apr 15, 2024
5 of 6 checks passed
@jamestrew
Copy link
Contributor

thanks again!

@jamestrew jamestrew added the backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat) label Apr 15, 2024
emmanueltouzery added a commit to emmanueltouzery/nvim_config that referenced this pull request Apr 16, 2024
fix which-key window crashing+it's now on top in neovide

nvim-telescope/telescope.nvim#3046
@shcode shcode deleted the fix/zindex-popup branch April 17, 2024 03:11
Conni2461 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

which_key action popup is not rendered correctly in neovide
3 participants