Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New xml format #7947

Merged
merged 17 commits into from
Mar 11, 2023
Merged

New xml format #7947

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3ce61bc
Change from_node_to_value to generate elements in new format
NotLebedev Feb 2, 2023
ab0af0a
Allow from_node_to_value to ignore some node types
NotLebedev Feb 2, 2023
1d67bc1
Add flags for keeping comments and processing instructions
NotLebedev Feb 2, 2023
677ef5d
Add text node conversion
NotLebedev Feb 2, 2023
1ce5229
Add comment and processing instruction parsing
NotLebedev Feb 7, 2023
3cbb867
Shorten name of keep-processing-instructions option
NotLebedev Feb 7, 2023
e935c4f
Change to xml to accept new format
NotLebedev Feb 25, 2023
ef8617f
Add comments and PIs
NotLebedev Feb 25, 2023
b873e59
Prevent comments, PIs and strings at top level of document
NotLebedev Feb 25, 2023
475e44f
Add shorthand for text content
NotLebedev Feb 25, 2023
db86aa9
Merge branch 'main' into new-xml-format
NotLebedev Feb 25, 2023
0f53fef
Fix test related to xml
NotLebedev Mar 10, 2023
89b0d2f
Fix clippy warnings
NotLebedev Mar 10, 2023
38a1711
Merge branch 'nushell:main' into new-xml-format
NotLebedev Mar 11, 2023
db5ffa8
Improve error handling in to xml
NotLebedev Mar 11, 2023
f8b9060
Add extras_usage for to xml and from xml
NotLebedev Mar 11, 2023
383c0bd
Improve error handling in from xml
NotLebedev Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add flags for keeping comments and processing instructions
  • Loading branch information
@NotLebedev
NotLebedev committed Feb 2, 2023
commit 1d67bc189a61f1815a059c744d60c086d391c6f1
4 changes: 4 additions & 0 deletions crates/nu-command/src/formats/from/xml.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ impl Command for FromXml {
fn signature(&self) -> Signature {
Signature::build("from xml")
.input_output_types(vec![(Type::String, Type::Record(vec![]))])
.switch("keep-comments", "add comment nodes to result", None)
.switch("keep-processing-instructions", "add processing instruction nodes to result", None)
.category(Category::Formats)
}

Expand All @@ -35,6 +37,8 @@ impl Command for FromXml {
input: PipelineData,
) -> Result<PipelineData, ShellError> {
let head = call.head;
let keep_comments = call.has_flag("keep-comments"); // TODO: implement
let keep_processing_instructions = call.has_flag("keep-processing-instructions"); // TODO: implement
from_xml(input, head)
}

Expand Down