New xml format #7947
Merged
New xml format #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm excited for this PR. XML has been a weak spot for a long time. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7947 +/- ##
==========================================
+ Coverage 68.25% 68.55% +0.30%
==========================================
Files 620 620
Lines 99355 99600 +245
==========================================
+ Hits 67813 68284 +471
+ Misses 31542 31316 -226
|
|
I'd still vote to re-run the CI and land this when it's green. It's better than what we have now. |
|
Seconding @fdncred. I vote we should land this, too. |
|
This should get mentioned as a breaking change/new feature in the 0.77 blog post. @NotLebedev do you have time to write that up today or would you like someone else to? nushell/nushell.github.io#800 |
Yes I have time. Will do shortly. |
Merged
fdncred
pushed a commit
that referenced
this pull request
Apr 5, 2023
# Description Add `xaccess`,`xupdate` and `xinsert` scripts to standard library. They allow accessing and manipulating data in new xml format #7947 with relative ease. Access some data in nushell xml structure:  Update attributes of xml tags matching a path:  # User-Facing Changes New commands `std xaccess`, `std xupdate` and `std xinsert` # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
39555
added a commit
to 39555/nu_scripts
that referenced
this pull request
May 12, 2024
`from xml` in modern `nu` has different shape. Output is now a series of records with tag, attributes and content fields nushell/nushell#7947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes old
from xmlto xmldata formats. See #7682 for reasoning behind this change.Output is now a series of records with
tag,attributesandcontentfields.Old:
New:
User-Facing Changes
New output/input format, better error handling for
from xmlandto xmlcommands.Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.