-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make seq
return a ListStream
where possible
#7367
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ mod run_external; | |
mod save; | ||
mod select; | ||
mod semicolon; | ||
mod seq; | ||
mod seq_char; | ||
mod shells; | ||
mod skip; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
use nu_test_support::{nu, pipeline}; | ||
|
||
#[test] | ||
fn float_in_seq_leads_to_lists_of_floats() { | ||
let actual = nu!( | ||
cwd: "tests/fixtures/formats", pipeline( | ||
r#" | ||
seq 1.0 0.5 6 | describe | ||
"# | ||
)); | ||
|
||
assert_eq!(actual.out, "list<float>"); | ||
} | ||
|
||
#[test] | ||
fn ints_in_seq_leads_to_lists_of_ints() { | ||
let actual = nu!( | ||
cwd: "tests/fixtures/formats", pipeline( | ||
r#" | ||
seq 1 2 6 | describe | ||
"# | ||
)); | ||
|
||
assert_eq!(actual.out, "list<int>"); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this has the same performance benefits of you last PR that you just closed related to this. I'm also wondering if calling
call.rest()
twice has some noticeable performance impact.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My gut feeling is that the performance impact of calling
rest()
twice will be negligible.