Make seq return a ListStream where possible
#7367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
fdncred
reviewed
Dec 6, 2022
| // everything had been generated; this does not work well with ListStreams. | ||
| // As such, the simple test is to check if this errors out: that means there is a float in the | ||
| // input, which necessarily means that parts of the output will be floats. | ||
| let rest_nums_check: Result<Vec<Spanned<i64>>, ShellError> = call.rest(engine_state, stack, 0); |
There was a problem hiding this comment.
I'm wondering if this has the same performance benefits of you last PR that you just closed related to this. I'm also wondering if calling call.rest() twice has some noticeable performance impact.
There was a problem hiding this comment.
My gut feeling is that the performance impact of calling rest() twice will be negligible.
rgwood
approved these changes
Dec 6, 2022
rgwood
added
the
streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
User-Facing Changes
Faster seq that works better with functions that take in
ListStreams.Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.