Make SQLite queries cancellable #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgwood
added
the
signal-cancel
fdncred
reviewed
Dec 4, 2022
|
I think being able to ctrl-c is a massive step in the right direction. I've been caught too many times in a massive db (crates.io db) or a "oh crap, i just ran the wrong query". Good work @rgwood!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes SQLite queries (
open foo.db,open foo.db | query db "select ...") cancellable usingctrl+c. Previously they were not cancellable, which made it unpleasant to accidentally open a very large database or run an unexpectedly slow query!UX-wise there's not too much to show:
Notes
I was hoping to make SQLite queries streamable as part of this work, but I ran into 2 problems:
rusqlitelifetimes are nightmarishly complex and they make it hard to create aListStreamiteratorCustomValuetrait returnValuenotPipelineDataand soCustomValueimplementations can't stream data AFAICT.