Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite loading can't be interrupted by ctrl+c #7333

Closed
rgwood opened this issue Dec 2, 2022 · 1 comment
Closed

SQLite loading can't be interrupted by ctrl+c #7333

rgwood opened this issue Dec 2, 2022 · 1 comment
Labels
signal-cancel Problems with how executions react to signals or attempts at cancellation (CTRL-C)
Milestone

Comments

@rgwood
Copy link
Contributor

rgwood commented Dec 2, 2022

Describe the bug

If you open foo.db on a large SQLite database, it will take a very long time and can't be interrupted by ctrl+c.

It's tricky to fix this because the SQLiteDatabase struct implements CustomValue, and CustomValue impls must derive Serialize+Deserialize because CustomValue uses typetag. And so we can't just add a ctrlc: Option<Arc<AtomicBool>> field to SQLiteDatabase because that can't be serialized...

This is getting into some rather complicated areas of Rust, hopefully someone can find a good solution.

How to reproduce

  1. open foo.db
  2. press ctrl+c, it does nothing

Expected behavior

ctrl+c should interrupt opening a database.

Screenshots

No response

Configuration

key value
version 0.72.1
branch main
commit_hash f71a452
build_os linux-x86_64
build_target x86_64-unknown-linux-gnu
rust_version rustc 1.65.0 (897e37553 2022-11-02)
rust_channel 1.65.0-x86_64-unknown-linux-gnu
cargo_version cargo 1.65.0 (4bc8f24d3 2022-10-20)
pkg_version 0.72.1
build_time 2022-12-01 09:23:26 -08:00
build_rust_channel release
features database, default, trash, which, zip
installed_plugins

Additional context

No response

@rgwood rgwood added the signal-cancel Problems with how executions react to signals or attempts at cancellation (CTRL-C) label Dec 2, 2022
@rgwood
Copy link
Contributor Author

rgwood commented Dec 9, 2022

Fixed by #7351

@rgwood rgwood closed this as completed Dec 9, 2022
@hustcer hustcer added this to the v0.73 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signal-cancel Problems with how executions react to signals or attempts at cancellation (CTRL-C)
Projects
None yet
Development

No branches or pull requests

2 participants