Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure exit codes in more cases #4803

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

sophiajt
Copy link
Contributor

Description

This adds more guards to ensure that we've seen an exit code before we move on. There were a few places in the repl and script runner that might have moved on before the external and fully completed. In theory, waiting on the exit code should help.

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt sophiajt merged commit 9abb14b into nushell:main Mar 10, 2022
@sophiajt sophiajt deleted the ensure_exit_code branch March 10, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant