Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals in loop should run to completion #4800

Closed
sophiajt opened this issue Mar 9, 2022 · 3 comments
Closed

Externals in loop should run to completion #4800

sophiajt opened this issue Mar 9, 2022 · 3 comments
Labels
🐛 bug Something isn't working
Milestone

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Mar 9, 2022

Describe the bug

From discord:

is there a way to detect when an outside script is finished executing?
Im currently having some code that look like this, but for some reason the next iteration is triggerd before ffmpeg finishes its previous run?

| each {|it|
        ffmpeg -loglevel quiet -y -i $it.path -c copy -c:s srt $"($it.path).mkv"
    }

How to reproduce

See above

Expected behavior

The externals in the loop should run to completion. You shouldn't have to use complete to force them to complete.

Screenshots

No response

Configuration

(unknown)

Additional context

No response

@sophiajt sophiajt added 0.60 🐛 bug Something isn't working labels Mar 9, 2022
@sophiajt
Copy link
Contributor Author

sophiajt commented Mar 9, 2022

If redirection is off, it's possible we spawn and move on. Need to special case that situation

@hustcer hustcer added this to the v0.60.0 milestone Mar 10, 2022
@sophiajt
Copy link
Contributor Author

It's possible this was fixed by #4803

@sophiajt
Copy link
Contributor Author

Going to mark this as closed without having a specific complete repro it's a little tricky to know for sure, but we're definitely waiting for more exits now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants