Reworking nufmt

[AucaCoyan]

Hi!

I still have to resolve some issues, and tests and other things, that's why this is still a draft

[fdncred]

Thanks. Looks good so far. Just ping me when you're ready for a review.

[amtoine]

i've started having a little look 😌

Note
files not reviewed at all

• formatting.rs
• lib.rs
• main.rs

[amtoine]

to help reviewing this file, is this a bad or a good file? 😏

[AucaCoyan]

I committed it as is. The reality is that if you open with vs code the extension of nushell complains in a couple lines. I'm not sure what to do with it yet

[amtoine]

mm okok

we might want to have a closer look at it when we decide to use it 👍

[fdncred]

There's also a work-in-progress style guide here nushell/nushell.github.io#904

[AucaCoyan]

Hello! I'm doing some progress. It is still quite messy, and with a lot of TODOs.
I managed to:

• make a cli that accept (many) files and one config
• read the file (in bytes)
• parse if it's correct nu lang
• match many tokens of the nu_parser::FlatShape (I have issues with some of them)
• write out the file passed to the CLI prompt. (So it formats the file in place)

I still have to:

• resolve every FlatShape enum pending
• be able to pass a string into the CLI (and format it)
• starting from a "whitespace-cleaned" file insert the whitespace according to the config (4 spaces, 100 max characters, configurable)

To resolve some specific questions, I will head for the nushell discord. Anyone is welcome to participate!

[amtoine]

@AucaCoyan
is there at least an nufmt we can run?

if it's the case, i'd vote to land this and address the missing points in follow up PRs 😌

[AucaCoyan]

is there at least an nufmt we can run?

if it's the case, i'd vote to land this and address the missing points in follow up PRs 😌

Yes!
You can clone the repo and run
cargo run -- folder\your-file.nu

or, if you want the trace log,
RUST_LOG="trace" cargo run -- folder\your-file.nu

[fdncred]

I'm fine with landing this as a step in the right direction, with a mind to keep iterating on it until we get it to where we want it to be.

[AucaCoyan]

Ok! I will keep working, for sure!
I will mark this PR to review and submit issues to point the places to improve / fix

[fdncred]

nice initial work!