-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port before_v0.60/fuzzy
, before_v0.60/ls-mods
and before_v0.60/nu_101
#845
Merged
fdncred
merged 13 commits into
nushell:main
from
39555:port-before_v0.60/fuzzy-ls-mods-nu-101
May 26, 2024
Merged
Port before_v0.60/fuzzy
, before_v0.60/ls-mods
and before_v0.60/nu_101
#845
fdncred
merged 13 commits into
nushell:main
from
39555:port-before_v0.60/fuzzy-ls-mods-nu-101
May 26, 2024
Commits on May 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d7ff2b7 - Browse repository at this point
Copy the full SHA d7ff2b7View commit details
Commits on May 25, 2024
-
- replace all `-` dashes in variable names with `_` - merge `help commands | get subcommands` and `help commands | reject subcommands` together because now `help commands` contains the flatten data - `$it.description` -> `$it.usage` - `seq $required-tabs` -> `seq 0 $required-tabs` - remove `echo $"(seq ...)"` -> seq ... - fix: assign fzf result to `let command` and then check with `is-not-empty` before sending to the `help` and the system clipboard - `str collect` -> `str join` - `get Column1` -> `get column1.0` explicitly get the first value from the table
Configuration menu - View commit details
-
Copy full SHA for 1699b56 - Browse repository at this point
Copy the full SHA 1699b56View commit details -
- `empty?` -> `is-empty` - `if {] {}` -> `if {} else {}`
Configuration menu - View commit details
-
Copy full SHA for 054861f - Browse repository at this point
Copy the full SHA 054861fView commit details -
- `empty?` -> `is-empty` - remove `echo` - remove additional `ansi_size` because `fill -l` already computes with ansi - `if {} {}` -> `if {} else {}` - remove empty else blocks - `each -n` -> `enumerate | each` - remove commented old code - explicitly join together strings with `let new_line` and $"()()" instead of old implicit return. line 39 - `str rpad -c` -> `fill -a r -c` - remove `autoview` - `str collect` -> `str join` - explicit `print`
Configuration menu - View commit details
-
Copy full SHA for 8912049 - Browse repository at this point
Copy the full SHA 8912049View commit details -
- `if {} {}` -> `if {} else {}` - remove logging - `empty?` -> `is-empty` - `each -n` -> `enumerate | each` - remove autoview - remove empty else blocks - add missing `let is_columns_empty =` in the `run_ls` function - `str collect` -> `str join` - str rpad lpad` -> `fill`
Configuration menu - View commit details
-
Copy full SHA for 9bff81f - Browse repository at this point
Copy the full SHA 9bff81fView commit details -
port
nu_101/inner_outer_loop.nu
- `str collect` -> `str join` - `$()()(char newline)` -> `$"()()"` and `str join (char newline)` do not print newline at the end, how it was in the old nu
Configuration menu - View commit details
-
Copy full SHA for 2004e0c - Browse repository at this point
Copy the full SHA 2004e0cView commit details -
- change flag -> optional positional argument for checking for the `null`. Flags now return a boolean value - `if {} {}` -> `if {} else {}` - remove unnecessary `echo` - `empty?` -> `is-empty` - `$true` `$false` -> `true` `false` - `$nothing` -> `null`
Configuration menu - View commit details
-
Copy full SHA for 2c879df - Browse repository at this point
Copy the full SHA 2c879dfView commit details -
fix: move the
nu_101
module tosourced
- delete the duplicated README.md from the old module - remove `demo.nu`. This script has already been ported to `sourced/nu_101/demo.nu` - move `nothing.nu` - move `inner_outer_loop.nu`
Configuration menu - View commit details
-
Copy full SHA for d0e0563 - Browse repository at this point
Copy the full SHA d0e0563View commit details -
- change `where` to `filter` for clarity, because we passing a closure - check `--dir` if empty
Configuration menu - View commit details
-
Copy full SHA for db6a65e - Browse repository at this point
Copy the full SHA db6a65eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e9655 - Browse repository at this point
Copy the full SHA b7e9655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fec130 - Browse repository at this point
Copy the full SHA 6fec130View commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c430bb0 - Browse repository at this point
Copy the full SHA c430bb0View commit details -
- move from `sourced/` to `modules/` - add `export`
Configuration menu - View commit details
-
Copy full SHA for 26e988d - Browse repository at this point
Copy the full SHA 26e988dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.