Port before_v0.60/fuzzy, before_v0.60/ls-mods and before_v0.60/nu_101
#845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace all `-` dashes in variable names with `_` - merge `help commands | get subcommands` and `help commands | reject subcommands` together because now `help commands` contains the flatten data - `$it.description` -> `$it.usage` - `seq $required-tabs` -> `seq 0 $required-tabs` - remove `echo $"(seq ...)"` -> seq ... - fix: assign fzf result to `let command` and then check with `is-not-empty` before sending to the `help` and the system clipboard - `str collect` -> `str join` - `get Column1` -> `get column1.0` explicitly get the first value from the table
- `empty?` -> `is-empty`
- `if {] {}` -> `if {} else {}`
- `empty?` -> `is-empty`
- remove `echo`
- remove additional `ansi_size` because `fill -l` already computes with ansi
- `if {} {}` -> `if {} else {}`
- remove empty else blocks
- `each -n` -> `enumerate | each`
- remove commented old code
- explicitly join together strings with `let new_line` and $"()()" instead of old implicit return. line 39
- `str rpad -c` -> `fill -a r -c`
- remove `autoview`
- `str collect` -> `str join`
- explicit `print`
- `if {} {}` -> `if {} else {}`
- remove logging
- `empty?` -> `is-empty`
- `each -n` -> `enumerate | each`
- remove autoview
- remove empty else blocks
- add missing `let is_columns_empty =` in the `run_ls` function
- `str collect` -> `str join`
- str rpad lpad` -> `fill`
- `str collect` -> `str join` - `$()()(char newline)` -> `$"()()"` and `str join (char newline)` do not print newline at the end, how it was in the old nu
- change flag -> optional positional argument for checking for the `null`. Flags now return a boolean value
- `if {} {}` -> `if {} else {}`
- remove unnecessary `echo`
- `empty?` -> `is-empty`
- `$true` `$false` -> `true` `false`
- `$nothing` -> `null`
|
i noticed some files are just moved over without changes. does that mean they already work or are you continuing to work on these? |
|
I found that I should move |
- delete the duplicated README.md from the old module - remove `demo.nu`. This script has already been ported to `sourced/nu_101/demo.nu` - move `nothing.nu` - move `inner_outer_loop.nu`
- change `where` to `filter` for clarity, because we passing a closure - check `--dir` if empty
|
Fix missing files done. All 11 files that have been changed in this PR:
|
39555
changed the title
before_v0.60/fuzzy, before_v0.60/ls-mods and before_v0.60/nu-101 before_v0.60/fuzzy, before_v0.60/ls-mods and before_v0.60/nu_101
|
modules need to have export, sourced do not |
- move from `sourced/` to `modules/` - add `export`
|
I moved |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and includes a set of modules:
modules/fuzzy/fuzzy_command_search.numodules/ls-mods:ls-less.nu,ls-wide.nuandls-wide-with-color.numodules/nu_101:nothing.nuandinner_outer_loop.nuEdit:
fuzzyandnu_101have been moved tosourced