Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible DkgPublicKey byte serialization #128

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jun 16, 2023

Type of PR:

  • Bugfix

Required reviews:

  • 1

What this does:

  • Fixes incompatibility of DkgPublicKey serialized to bytes between Python and WASM bindings

Why it's needed:

  • Previously added serialization method only affected Python bindings and caused incompatibility with WASM bindings

Notes for reviewers:

  • Now downstream effect on nucypher

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review June 16, 2023 12:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #128 (e516562) into development (ccdc209) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development     #128      +/-   ##
===============================================
- Coverage        79.09%   78.78%   -0.31%     
===============================================
  Files               24       24              
  Lines             4850     4869      +19     
===============================================
  Hits              3836     3836              
- Misses            1014     1033      +19     
Impacted Files Coverage Δ
ferveo/src/api.rs 88.79% <0.00%> (-0.78%) ⬇️
ferveo/src/bindings_python.rs 54.76% <0.00%> (+0.08%) ⬆️
ferveo/src/bindings_wasm.rs 0.00% <0.00%> (ø)
ferveo/src/lib.rs 97.40% <ø> (ø)

@derekpierre
Copy link
Member

Only the last 3 commits are relevant - For some reason GH still renders commits from #127 after rebase

It seems that main is ahead of development... development...nucypher:ferveo:main

Is the intention for this PR to merge into development or main?

@piotr-roslaniec
Copy link
Author

Is the intention for this PR to merge into development or main?

To merge into development.

I rebase the development branch over main branch. The HEAD of both of these branches should point to the same commit, i.e. before this PR is merged these branches should be the same.

@derekpierre
Copy link
Member

You'll need to rebase this PR branch over development again then, and the additional commits should go away.

@piotr-roslaniec
Copy link
Author

That worked, thanks!

Copy link
Member

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotr-roslaniec piotr-roslaniec merged commit ad22f46 into development Jun 21, 2023
9 checks passed
@piotr-roslaniec piotr-roslaniec deleted the fix-dkg-pk-deser-wasm branch June 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants