Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide DkgPublicParams from external API #127

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Hide DkgPublicParams from external API #127

merged 1 commit into from
Jun 19, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jun 14, 2023 •
edited
Loading

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

  • Removes DkgPublicKey from public API (bindings) and replaces it with a default value internally

Why it's needed:

  • Simplifies user API

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec changed the base branch from hide-dkg-public-params to main June 14, 2023 14:08
@piotr-roslaniec piotr-roslaniec force-pushed the hide-dkg-public-params branch 3 times, most recently from 4c0b21d to 1d75d29 Compare June 14, 2023 14:33
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review June 14, 2023 14:45
@derekpierre derekpierre mentioned this pull request Jun 14, 2023
Closed
@piotr-roslaniec piotr-roslaniec mentioned this pull request Jun 14, 2023
Closed
@piotr-roslaniec piotr-roslaniec mentioned this pull request Jun 16, 2023
Merged
@theref
Copy link

theref commented Jun 19, 2023

love this 🪓

@piotr-roslaniec piotr-roslaniec merged commit ccdc209 into nucypher:main Jun 19, 2023
@derekpierre
Copy link
Member

Will this have downstream effects in nucypher-core/nucypher?

@piotr-roslaniec
Copy link
Author

piotr-roslaniec commented Jun 19, 2023 •
edited
Loading

From the perspective of nucypher-core etc this is not a breaking change since related bindings are not used anywhere directly, they are just re-exported from nucypher-core instead.

From the perspective of nucypher it may cause some changes - I imagine these API is at the least used in tests.

I can create issues to track these changes where needed.

@derekpierre
Copy link
Member

I can create issues to track these changes where needed.

👍 - It would be good to have these filed / tracked, and owned by someone.

This was referenced Jun 20, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theref theref theref approved these changes

@cygnusv cygnusv Awaiting requested review from cygnusv

@derekpierre derekpierre Awaiting requested review from derekpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-roslaniec @theref @derekpierre