fix(worker): Remove custom Slack provider handling in send-message-chat #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Aug 15, 2024
| @@ -405,7 +405,7 @@ export class SendMessageChat extends SendMessageBase { | |||
| customData: overrides, | |||
| webhookUrl: chatWebhookUrl, | |||
| channel: channelSpecification, | |||
| ...(bridgeContent?.content ? bridgeContent : { content }), | |||
| content, | |||
There was a problem hiding this comment.
We provide the fully resolved content directly to the chatHandler now
rifont
commented
Aug 15, 2024
| @@ -88,7 +88,8 @@ export class SendMessageChat extends SendMessageBase { | |||
| step.template = template; | |||
| } | |||
|
|
|||
| let content = ''; | |||
| const bridgeOutput = command.bridgeData?.outputs as ChatOutput | undefined; | |||
| let content: string = bridgeOutput?.body || ''; | |||
There was a problem hiding this comment.
Fully resolving the content here.
davidsoderberg
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Before - duplicate Slack blocks content due to
blocksmapping to "trigger data"After - no more duplicate messages
Expand for optional sections
Related enterprise PR
Special notes for your reviewer