-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add usage of bridge provider options in send message usecases a… #6062
Merged
rifont
merged 70 commits into
next
from
nv-4109-add-support-for-sending-generic-bridge-provider-data-during
Aug 8, 2024
Merged
feat(api): add usage of bridge provider options in send message usecases a… #6062
rifont
merged 70 commits into
next
from
nv-4109-add-support-for-sending-generic-bridge-provider-data-during
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
reviewed
Jul 15, 2024
apps/api/src/app/events/usecases/send-test-email/send-test-email.usecase.ts
Show resolved
Hide resolved
rifont
reviewed
Jul 15, 2024
apps/api/src/app/events/usecases/send-test-email/send-test-email.usecase.ts
Outdated
Show resolved
Hide resolved
rifont
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When delivering a message to a 3rd party provider in the Worker engine, we need to ensure that the Bridge provider data is given to the Delivery Provider resolver during the delivery flow.
Why? (Context)
Bridge provider data should be used when delivery messages via a Delivery Provider.
Screens
![image](https://private-user-images.githubusercontent.com/32132657/356184074-944b7bfd-f2f3-4f87-882d-fbc973980134.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzMjc5NjYsIm5iZiI6MTcyNTMyNzY2NiwicGF0aCI6Ii8zMjEzMjY1Ny8zNTYxODQwNzQtOTQ0YjdiZmQtZjJmMy00Zjg3LTg4MmQtZmJjOTczOTgwMTM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAzVDAxNDEwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxZDBhMTljMjkxZWQ1MTgxZTZiMTAyNWM5YTQxOWRkYTlkMWFhZDMyNTVjYjNjNWU3ZTczMzYxYzExNjVhYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NEJnW-Id9ZD22la9e-xHwcKMoqJOTTsfMdgTevoS6Vw)
Precedence of provider data resolution
Demonstration of precedence in Provider dashboard (Twilio)
![image](https://private-user-images.githubusercontent.com/32132657/356184041-680c9eac-20fb-4e75-bce1-da5c5ba3af69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzMjc5NjYsIm5iZiI6MTcyNTMyNzY2NiwicGF0aCI6Ii8zMjEzMjY1Ny8zNTYxODQwNDEtNjgwYzllYWMtMjBmYi00ZTc1LWJjZTEtZGE1YzViYTNhZjY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAzVDAxNDEwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NjE1OWVjMzBjZmY5NWE0MGQ4OTM3NTk1YjJlOTNmZmEzNmM3NmM1Mjg1YjhhYTViYWM0NmFjZGQzZDk0YmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lkoxabeocfb8C85K1MZRU0YkyjXDWkmDx-PxMop4Flk)