Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #23732, os.sleep(-1) now returns immediately #23734

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fixes #23732, os.sleep(-1) now returns immediately #23734

merged 2 commits into from
Jun 18, 2024

Conversation

litlighilit
Copy link
Contributor

@litlighilit litlighilit commented Jun 18, 2024 •
edited
Loading

fixes #23732

@ringabout
Copy link
Member

See also #17149

@litlighilit
Copy link
Contributor Author

litlighilit commented Jun 18, 2024 •
edited
Loading

See also #17149

This PR also updates the doc,

so hopefully it can be said to solve this issue, too.

Anyway, there are langs like golang, accepting a negative value and doing nothing for it.

@litlighilit
Copy link
Contributor Author

for ci:

sigh.
I'd say this PR does nothing for macos but ci for macos failed...

@ringabout
Copy link
Member

I'd say this PR does nothing for macos but ci for macos failed...

It's a known issue => #23728

@Araq Araq merged commit 2a658c6 into nim-lang:devel Jun 18, 2024
18 of 19 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 2a658c6

Hint: mm: orc; opt: speed; options: -d:release
178823 lines; 8.439s; 664.246MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadloop in Windows, os.sleep(-1)
3 participants
@litlighilit @ringabout @Araq