Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable dnsclient because it is fragile #23728

Merged
merged 1 commit into from
Jun 18, 2024
Merged

disable dnsclient because it is fragile #23728

merged 1 commit into from
Jun 18, 2024

Conversation

ringabout
Copy link
Member

  Unhandled exception: /home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1.nim(28, 3) `rr.strings == @["dnsclient.nim"]`  [AssertionDefect]
  [FAILED] query TXT
  [OK] query MX
  [OK] query CNAME
  [OK] query SRV
  Error: execution of an external program failed: '/home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1'
         Tip: 2 messages have been suppressed, use --verbose to show them.
  tools.nim(36)            doCmd
  
      Error:  Execution failed with exit code 1
          ... Command: /home/runner/work/Nim/Nim/bin/nim c --noNimblePath -d:NimblePkgVersion=0.3.4 --hints:off -r --path:. /home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1 

@ringabout
Copy link
Member Author

It sends queries to http:https://txt.example.huy.im/, which is quite suspious

test "query TXT":
  let resp = client.sendQuery("txt.example.huy.im", TXT)
  assert resp.answers[0].kind == TXT
  let rr = TXTRecord(resp.answers[0])
  assert rr.strings == @["dnsclient.nim"]

@ringabout ringabout marked this pull request as draft June 18, 2024 02:56
@ringabout ringabout marked this pull request as ready for review June 18, 2024 11:43
@ringabout
Copy link
Member Author

cc @ba0f3

@ringabout ringabout merged commit c58b6e8 into devel Jun 18, 2024
16 checks passed
@ringabout ringabout deleted the ringabout-patch-9 branch June 18, 2024 11:43
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c58b6e8

Hint: mm: orc; opt: speed; options: -d:release
178820 lines; 8.336s; 664.246MiB peakmem

@ba0f3
Copy link
Contributor

ba0f3 commented Jun 19, 2024

It sends queries to http:https://txt.example.huy.im/, which is quite suspious

test "query TXT":
  let resp = client.sendQuery("txt.example.huy.im", TXT)
  assert resp.answers[0].kind == TXT
  let rr = TXTRecord(resp.answers[0])
  assert rr.strings == @["dnsclient.nim"]

it does not send http request to http:https://txt.example.huy.im/, it asked for TXT record txt.example.huy.im via DNS protocol

narimiran pushed a commit that referenced this pull request Jun 24, 2024
```
  Unhandled exception: /home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1.nim(28, 3) `rr.strings == @["dnsclient.nim"]`  [AssertionDefect]
  [FAILED] query TXT
  [OK] query MX
  [OK] query CNAME
  [OK] query SRV
  Error: execution of an external program failed: '/home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1'
         Tip: 2 messages have been suppressed, use --verbose to show them.
  tools.nim(36)            doCmd

      Error:  Execution failed with exit code 1
          ... Command: /home/runner/work/Nim/Nim/bin/nim c --noNimblePath -d:NimblePkgVersion=0.3.4 --hints:off -r --path:. /home/runner/work/Nim/Nim/pkgstemp/dnsclient/tests/test1
```

(cherry picked from commit c58b6e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants