test(services): apply mock and naming conventions

service/amazonsns/amazon_sns.go

@@ -11,6 +11,8 @@ import (
 )
 
 // SNSSendMessageAPI Basic interface to send messages through SNS.
+//
+//go:generate mockery --name=SNSSendMessageAPI --output=. --case=underscore --inpackage
 type SNSSendMessageAPI interface {
  SendMessage(ctx context.Context,
  params *sns.PublishInput,

service/amazonsns/amazon_sns_test.go

@@ -8,21 +8,20 @@ import (
  "github.com/aws/aws-sdk-go-v2/service/sns"
  "github.com/stretchr/testify/assert"
  "github.com/stretchr/testify/mock"
+ "github.com/stretchr/testify/require"
 )
 
-type SNSSendMessageMock struct {
- mock.Mock
-}
+func TestAmazonSNS_New(t *testing.T) {
+ t.Parallel()
+
+ assert := require.New(t)
 
-func (m *SNSSendMessageMock) SendMessage(ctx context.Context,
- params *sns.PublishInput,
- optFns ...func(*sns.Options),
-) (*sns.PublishOutput, error) {
- args := m.Called(ctx, params, optFns)
- return args.Get(0).(*sns.PublishOutput), args.Error(1)
+ service, err := New("", "", "")
+ assert.NotNil(service)
+ assert.Nil(err)
 }
 
-func TestAddReceivers(t *testing.T) {
+func TestAmazonSNS_AddReceivers(t *testing.T) {
  t.Parallel()
 
  amazonSNS, err := New("", "", "")
@@ -32,10 +31,10 @@ func TestAddReceivers(t *testing.T) {
  amazonSNS.AddReceivers("One topic")
 }
 
-func TestSendMessageWithNoTopicsConfigured(t *testing.T) {
+func TestAmazonSNS_SendMessageWithNoTopicsConfigured(t *testing.T) {
  t.Parallel()
 
- mockSns := new(SNSSendMessageMock)
+ mockSns := new(MockSNSSendMessageAPI)
  amazonSNS := AmazonSNS{
  sendMessageClient: mockSns,
  }
@@ -45,10 +44,10 @@ func TestSendMessageWithNoTopicsConfigured(t *testing.T) {
  mockSns.AssertNotCalled(t, "SendMessage", mock.Anything, mock.Anything, mock.Anything)
 }
 
-func TestSendMessageWithSucessAndOneTopicCOnfigured(t *testing.T) {
+func TestAmazonSNS_SendMessageWithSucessAndOneTopicConfigured(t *testing.T) {
  t.Parallel()
 
- mockSns := new(SNSSendMessageMock)
+ mockSns := new(MockSNSSendMessageAPI)
  output := sns.PublishOutput{}
  mockSns.On("SendMessage", mock.Anything, mock.Anything, mock.Anything).
  Return(&output, nil)
@@ -64,10 +63,10 @@ func TestSendMessageWithSucessAndOneTopicCOnfigured(t *testing.T) {
  assert.Equal(t, 1, len(mockSns.Calls))
 }
 
-func TestSendMessageWithSucessAndTwoTopicCOnfigured(t *testing.T) {
+func TestAmazonSNS_SendMessageWithSucessAndTwoTopicsConfigured(t *testing.T) {
  t.Parallel()
 
- mockSns := new(SNSSendMessageMock)
+ mockSns := new(MockSNSSendMessageAPI)
  output := sns.PublishOutput{}
  mockSns.On("SendMessage", mock.Anything, mock.Anything, mock.Anything).
  Return(&output, nil)
@@ -86,10 +85,10 @@ func TestSendMessageWithSucessAndTwoTopicCOnfigured(t *testing.T) {
  assert.Equal(t, 2, len(mockSns.Calls))
 }
 
-func TestSendMessageWithErrorAndOneQueueConfiguredShouldReturnError(t *testing.T) {
+func TestAmazonSNS_SendMessageWithErrorAndOneQueueConfiguredShouldReturnError(t *testing.T) {
  t.Parallel()
 
- mockSns := new(SNSSendMessageMock)
+ mockSns := new(MockSNSSendMessageAPI)
  output := sns.PublishOutput{}
  mockSns.On("SendMessage", mock.Anything, mock.Anything, mock.Anything).
  Return(&output, errors.New("Error on SNS"))
@@ -107,10 +106,10 @@ func TestSendMessageWithErrorAndOneQueueConfiguredShouldReturnError(t *testing.T
  assert.Equal(t, 1, len(mockSns.Calls))
 }
 
-func TestSendMessageWithErrorAndTwoQueueConfiguredShouldReturnErrorOnFirst(t *testing.T) {
+func TestAmazonSNS_SendMessageWithErrorAndTwoQueueConfiguredShouldReturnErrorOnFirst(t *testing.T) {
  t.Parallel()
 
- mockSns := new(SNSSendMessageMock)
+ mockSns := new(MockSNSSendMessageAPI)
  output := sns.PublishOutput{}
  mockSns.On("SendMessage", mock.Anything, mock.Anything, mock.Anything).
  Return(&output, errors.New("Error on SNS"))

service/discord/discord_test.go

@@ -8,7 +8,7 @@ import (
  "github.com/stretchr/testify/require"
 )
 
-func TestNew(t *testing.T) {
+func TestDiscord_New(t *testing.T) {
  t.Parallel()
 
  assert := require.New(t)

service/fcm/fcm.go

@@ -23,6 +23,8 @@ type (
 )
 
 // fcmClient abstracts go-fcm for writing unit tests
+//
+//go:generate mockery --name=fcmClient --output=. --case=underscore --inpackage
 type fcmClient interface {
  SendWithRetry(*fcm.Message, int) (*fcm.Response, error)
 }

service/fcm/fcm_test.go

@@ -9,7 +9,17 @@ import (
  "github.com/stretchr/testify/require"
 )
 
-func TestAddReceivers(t *testing.T) {
+func TestFCM_New(t *testing.T) {
+ t.Parallel()
+
+ assert := require.New(t)
+
+ service, err := New("server-api-key")
+ assert.NotNil(service)
+ assert.Nil(err)
+}
+
+func TestFCM_AddReceivers(t *testing.T) {
  t.Parallel()
 
  assert := require.New(t)
@@ -23,7 +33,7 @@ func TestAddReceivers(t *testing.T) {
  assert.Equal(svc.deviceTokens, deviceTokens)
 }
 
-func TestSend(t *testing.T) {
+func TestFCM_Send(t *testing.T) {
  t.Parallel()
 
  assert := require.New(t)
@@ -38,7 +48,7 @@ func TestSend(t *testing.T) {
  }
 
  // test fcm client send
- mockClient := newMockFCMClient(t)
+ mockClient := newMockFcmClient(t)
  mockClient.On("SendWithRetry", &fcm.Message{
  To: mockToken,
  Notification: &fcm.Notification{
@@ -54,7 +64,7 @@ func TestSend(t *testing.T) {
  mockClient.AssertExpectations(t)
 
  // test fcm client send with data
- mockClient = newMockFCMClient(t)
+ mockClient = newMockFcmClient(t)
  mockClient.On("SendWithRetry", &fcm.Message{
  To: mockToken,
  Data: mockData,
@@ -72,7 +82,7 @@ func TestSend(t *testing.T) {
  mockClient.AssertExpectations(t)
 
  // test fcm client send with data and retries
- mockClient = newMockFCMClient(t)
+ mockClient = newMockFcmClient(t)
  mockClient.On("SendWithRetry", &fcm.Message{
  To: mockToken,
  Data: mockData,
@@ -91,7 +101,7 @@ func TestSend(t *testing.T) {
  mockClient.AssertExpectations(t)
 
  // test fcm client returning error
- mockClient = newMockFCMClient(t)
+ mockClient = newMockFcmClient(t)
  mockClient.On("SendWithRetry", &fcm.Message{
  To: mockToken,
  Data: mockData,
@@ -111,7 +121,7 @@ func TestSend(t *testing.T) {
 
  // test fcm client multiple receivers
  anotherMockToken := "another_device_token"
- mockClient = newMockFCMClient(t)
+ mockClient = newMockFcmClient(t)
  mockClient.On("SendWithRetry", &fcm.Message{
  To: mockToken,
  Data: mockData,
@@ -138,7 +148,7 @@ func TestSend(t *testing.T) {
  mockClient.AssertExpectations(t)
 }
 
-func TestGetMessageData(t *testing.T) {
+func TestFCM_GetMessageData(t *testing.T) {
  t.Parallel()
 
  assert := require.New(t)
@@ -179,7 +189,7 @@ func TestGetMessageData(t *testing.T) {
  assert.True(ok)
 }
 
-func TestGetMessageRetryAttempts(t *testing.T) {
+func TestFCM_GetMessageRetryAttempts(t *testing.T) {
  t.Parallel()
 
  assert := require.New(t)

service/lark/common.go

@@ -1,11 +1,15 @@
 package lark
 
 // sender is an interface for sending a message to an already defined receiver.
+//
+//go:generate mockery --name=sender --output=. --case=underscore --inpackage
 type sender interface {
  Send(subject, message string) error
 }
 
 // sender is an interface for sending a message to a specific receiver ID.
+//
+//go:generate mockery --name=sendToer --output=. --case=underscore --inpackage
 type sendToer interface {
  SendTo(subject, message, id, idType string) error
 }