Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(services): apply mock and naming conventions #391

Merged
merged 15 commits into from
Sep 12, 2022
Merged

test(services): apply mock and naming conventions #391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3a57b6d
test: apply test conventions for amazon sns service
svaloumas Sep 12, 2022
6ad3b2e
test: apply test conventions for discord service
svaloumas Sep 12, 2022
6ec42eb
test: apply test conventions for fcm service
svaloumas Sep 12, 2022
5253743
test: apply test conventions for lark service
svaloumas Sep 12, 2022
8af0b6a
test: apply test conventions for msteams service
svaloumas Sep 12, 2022
74d4576
test: apply test conventions for plivo service
svaloumas Sep 12, 2022
2035e81
test: apply test conventions for slack service
svaloumas Sep 12, 2022
e9cf4be
test: apply test conventions for syslog service
svaloumas Sep 12, 2022
ecaa74a
test: apply test conventions for twilio service
svaloumas Sep 12, 2022
29809e5
test: apply test conventions for wechat service
svaloumas Sep 12, 2022
0c8245d
test: apply test conventions for whatsapp service
svaloumas Sep 12, 2022
528ac06
chore: gofumpt changes
svaloumas Sep 12, 2022
2e18096
Merge branch 'main' into test/apply-mock-and-naming-conventions-in-tests
nikoksr Sep 12, 2022
3c51987
refactor(service): make most amazon_sns types unexported
nikoksr Sep 12, 2022
b8bf94f
style(fmt): make fmt
nikoksr Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: apply test conventions for wechat service
  • Loading branch information
@svaloumas
svaloumas committed Sep 12, 2022
commit 29809e50f8ef5687813df4168caa482f9034c7ab
17 changes: 16 additions & 1 deletion service/wechat/mock_wechatMessageManager.go → ...ice/wechat/mock_wechat_message_manager.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions service/wechat/wechat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ type Config struct {
}

// wechatMessageManager abstracts go-wechat's message.Manager for writing unit tests
//
//go:generate mockery --name=wechatMessageManager --output=. --case=underscore --inpackage
type wechatMessageManager interface {
Send(msg *message.CustomerMessage) error
}
Expand Down
18 changes: 16 additions & 2 deletions service/wechat/wechat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,25 @@ import (
"testing"

"github.com/pkg/errors"
"github.com/silenceper/wechat/v2/cache"
"github.com/silenceper/wechat/v2/officialaccount/message"
"github.com/stretchr/testify/require"
)

func TestAddReceivers(t *testing.T) {
func TestWeChat_New(t *testing.T) {
t.Parallel()

assert := require.New(t)

cache := &cache.Memory{}
cfg := &Config{
Cache: cache,
}
service := New(cfg)
assert.NotNil(service)
}

func TestWeChat_AddReceivers(t *testing.T) {
t.Parallel()

assert := require.New(t)
Expand All @@ -23,7 +37,7 @@ func TestAddReceivers(t *testing.T) {
assert.Equal(svc.userIDs, userIDs)
}

func TestSend(t *testing.T) {
func TestWeChat_Send(t *testing.T) {
t.Parallel()

assert := require.New(t)
Expand Down