Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/crop undo #83

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix/crop undo #83

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e485a5
fix: cropzone remains after undo operation after crop
jinwoo-kim-nhn Oct 26, 2018
8100d3b
fix: Added test spec for crop redo bug
jinwoo-kim-nhn Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
fix: cropzone remains after undo operation after crop
  • Loading branch information
@jinwoo-kim-nhn
jinwoo-kim-nhn committed Oct 26, 2018
commit 2e485a59b68efba2695a061cb9fdf4f0d7c14ab9
3 changes: 2 additions & 1 deletion src/js/command/loadImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ const command = {
undo(graphics) {
const loader = graphics.getComponent(IMAGE_LOADER);
const {objects, name, image} = this.undoData;
const filteredObject = objects.filter(objectItem => objectItem.type !== 'cropzone');

graphics.removeAll(true);
graphics.add(objects);
graphics.add(filteredObject);

return loader.load(name, image);
}
Expand Down