Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/crop undo #83

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix/crop undo #83

merged 2 commits into from
Oct 31, 2018

Conversation

jinwoo-kim-nhn
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn commented Oct 30, 2018 •
edited

work

  • crop 기능 실행 후 되돌리기를 실행하면 cropzone 객체 까지 함께 되돌려지는 버그 수정
    • 되돌리기된 상태에 cropzone은 필요 없음으로 필터링 하여 제외 시킴
  • undoData 에 저장되는 Objects(shape or icon) 에 evented 속성이 false로 저장되는 버그 수정
    • crop이 시작될때는 Object들이 선택 안되도록 evented 속성을 일부로 false로 바꾸어 주지만, 이전 상태를 저장할때는 evented를 true로 변경 후 저장해야 한다.

sohee-lee7
sohee-lee7 reviewed Oct 31, 2018
View reviewed changes
Copy link

@sohee-lee7 sohee-lee7 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[10/31] 이견없습니다. 고생하셨습니다 👍

@seonim-ryu
Copy link
Member

[10/31] 간단하네요ㅎ 이견 없습니다.

@jungeun-cho
Copy link
Contributor

[10/31] 이견 없습니다. 수고하셨습니다.

@jinwoo-kim-nhn jinwoo-kim-nhn merged commit fd1bbc0 into master Oct 31, 2018
@1001v
Copy link

1001v commented Nov 5, 2018

Please update package version to provide this fix for npm.

@junghwan-park junghwan-park deleted the fix/crop-undo branch January 30, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohee-lee7 sohee-lee7 sohee-lee7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jinwoo-kim-nhn @seonim-ryu @jungeun-cho @1001v @sohee-lee7