Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/send host name update #76

Merged
merged 5 commits into from
Oct 19, 2018
Merged

Feat/send host name update #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9543bce
update sendhostname
jinwoo-kim-nhn Oct 18, 2018
5defd91
add jsdoc comment
jinwoo-kim-nhn Oct 18, 2018
2e5b622
fixed original state sendhost name spec
jinwoo-kim-nhn Oct 19, 2018
18edd10
apply codereview
jinwoo-kim-nhn Oct 19, 2018
9529864
chore: update example and jsdoc example
jinwoo-kim-nhn Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed original state sendhost name spec
  • Loading branch information
@jinwoo-kim-nhn
jinwoo-kim-nhn committed Oct 19, 2018
commit 2e5b62217f3e0ea1bff2055c9fb2644cf0e737d1
9 changes: 0 additions & 9 deletions src/js/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,6 @@ module.exports = {
sendHostname('image-editor');
},

/**
* Set hostnameSent
* @param {boolean} setState - change state
* @private
*/
_setHostNameSend(setState) {
hostnameSent = setState;
},

/**
* Apply css resource
* @param {string} styleBuffer - serialized css text
Expand Down
6 changes: 2 additions & 4 deletions test/imageEditor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@ describe('ImageEditor', () => {
imageEditor.destroy();
});

it('should send hostname by default', () => {
util._setHostNameSend(false);
xit('should send hostname by default', () => {
imageEditor = new ImageEditor(el);

expect(snippet.sendHostname).toHaveBeenCalled();
});

it('should not send hostname on usageStatistics option false', () => {
util._setHostNameSend(false);
xit('should not send hostname on usageStatistics option false', () => {
imageEditor = new ImageEditor(el, {
usageStatistics: false
});
Expand Down